Thread (1 message) 1 message, 1 author, 2015-09-17

Re: [PATCH 1/3] of/irq: add a dummy of_msi_configure if OF_IRQ=n

From: Rob Herring <hidden>
Date: 2015-09-17 19:32:17

On Mon, Sep 7, 2015 at 7:37 AM, Jonas Gorski [off-list ref] wrote:
quoted hunk
It is unconditionally called from of_platform_device_create_pdata, which
does not depend on OF_IRQ, just OF_ADDRESS.

Fixes: c706c239 ("of/platform: Assign MSI domain to platform device")
Signed-off-by: Jonas Gorski <redacted>
---
 include/linux/of_irq.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
index d884929..7b81771 100644
--- a/include/linux/of_irq.h
+++ b/include/linux/of_irq.h
@@ -86,6 +86,10 @@ static inline void *of_irq_find_parent(struct device_node *child)
 {
        return NULL;
 }
+
+static inline void of_msi_configure(struct device *dev, struct device_node *np)
+{
+}
Why do you add it here and then move it in patch #2? Just do this in 1 patch.

Rob
 #endif /* !CONFIG_OF */

 #endif /* __OF_IRQ_H */
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help