Re: [PATCH 2/3] devicetree: bindings: use input-event-codes.h for evdev codes
From: Ian Campbell <hidden>
Date: 2015-09-15 11:24:52
Also in:
linux-arm-kernel, linux-input
On Sat, 2015-09-12 at 15:26 +0200, Hans de Goede wrote:
quoted hunk ↗ jump to hunk
Add a symlink to uapi/linux/input-event-codes.h, and include that instead of (re)defining all the evdev type and code values in dt-bindings/input/input.h. This way we do not need to keep all the event codes synced manually. Signed-off-by: Hans de Goede <redacted> --- include/dt-bindings/input/input-event-codes.h | 1 + include/dt-bindings/input/input.h | 510 +------------------- ------ 2 files changed, 2 insertions(+), 509 deletions(-) create mode 120000 include/dt-bindings/input/input-event-codes.hdiff --git a/include/dt-bindings/input/input-event-codes.h b/include/dt -bindings/input/input-event-codes.h new file mode 120000 index 0000000..693bbcd --- /dev/null +++ b/include/dt-bindings/input/input-event-codes.h@@ -0,0 +1 @@ +../../uapi/linux/input-event-codes.h\ No newline at end of file
Hrm, I think this is going to cause trouble for the split DT repository at https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Since ../../ == include in both trees I think I can make it work by including include/uapi/linux in the conversion, either wholesale (easiest) or partially (potentially cleaner). Any opinions on that? In principal I ought to regenerate the tree from scratch such that include/uapi/linux was "always" there and has history but I think we can live with it just appearing at some point in time wen the conversion script was updated? AIUI these values are required to only be used with properties whose names are of the form "linux,*", otherwise there would be strong complaints about include Linux uapi stuff into a generic device-tree binding. Ian.