Thread (14 messages) 14 messages, 3 authors, 2015-09-29

Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition

From: Ivan T. Ivanov <hidden>
Date: 2015-09-19 04:56:42
Also in: linux-arm-msm, linux-serial, lkml

On Sep 19, 2015, at 2:33 AM, Stephen Boyd [off-list ref] wrote:

On 09/12, Ivan T. Ivanov wrote:
quoted
Stale Event Enable command should be 5 not 8, fix this.

Signed-off-by: Ivan T. Ivanov <redacted>
---
drivers/tty/serial/msm_serial.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
index 60917d30c6b5..223f961f992a 100644
--- a/drivers/tty/serial/msm_serial.h
+++ b/drivers/tty/serial/msm_serial.h
@@ -59,7 +59,7 @@
#define UART_CR_CMD_SET_RFR		(13 << 4)
#define UART_CR_CMD_RESET_RFR		(14 << 4)
#define UART_CR_CMD_PROTECTION_EN	(16 << 4)
-#define UART_CR_CMD_STALE_EVENT_ENABLE	(80 << 4)
+#define UART_CR_CMD_STALE_EVENT_ENABLE	(5 << 8)
I don't get this one

5 << 8 == 80 << 4

so this makes no difference.

Uh, of course. It is not 0x80. 

Regards,
Ivan--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help