Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings
From: Hans de Goede <hidden>
Date: 2015-09-09 10:57:25
Also in:
linux-ide, lkml
Hi, On 09-09-15 11:16, Yuantian.Tang@freescale.com wrote:
From: Tang Yuantian <redacted> kbuild test robot reports the warnings: drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':quoted
quoted
include/asm-generic/io.h:163:2: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized]drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared herequoted
quoted
include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used uninitialized in this function [-Wuninitialized]drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here This patch fixed it by assigning 0 to px_is and px_cmd variables. This patch also remove line 'struct ccsr_ahci *reg_base' which is not referred by any other codes and thus a dead one. Signed-off-by: Tang Yuantian <redacted>
LGTM: Acked-by: Hans de Goede [off-list ref] Regards, Hans
quoted hunk ↗ jump to hunk
--- drivers/ata/ahci_qoriq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index e5e4988..f790852 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c@@ -49,7 +49,6 @@ enum ahci_qoriq_type { }; struct ahci_qoriq_priv { - struct ccsr_ahci *reg_base; enum ahci_qoriq_type type; void __iomem *ecc_addr; };@@ -67,7 +66,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, { const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); void __iomem *port_mmio = ahci_port_base(link->ap); - u32 px_cmd, px_is, px_val; + u32 px_cmd = 0, px_is = 0, px_val; struct ata_port *ap = link->ap; struct ahci_port_priv *pp = ap->private_data; struct ahci_host_priv *hpriv = ap->host->private_data;