Thread (10 messages) 10 messages, 3 authors, 2015-09-03

Re: [STLinux Kernel] [PATCH v3 1/6] ARM: STi: Add DT defines for co-processor reset lines

From: Peter Griffin <peter.griffin@linaro.org>
Date: 2015-09-03 16:31:35
Also in: linux-arm-kernel, lkml

Hi Lee,

On Wed, 02 Sep 2015, Lee Jones wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Lee Jones <redacted>
---
 include/dt-bindings/reset-controller/stih407-resets.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/dt-bindings/reset-controller/stih407-resets.h b/include/dt-bindings/reset-controller/stih407-resets.h
index 02d4328..4ab3a1c 100644
--- a/include/dt-bindings/reset-controller/stih407-resets.h
+++ b/include/dt-bindings/reset-controller/stih407-resets.h
@@ -52,6 +52,10 @@
 #define STIH407_KEYSCAN_SOFTRESET	26
 #define STIH407_USB2_PORT0_SOFTRESET	27
 #define STIH407_USB2_PORT1_SOFTRESET	28
+#define STIH407_ST231_AUD_SOFTRESET	29
+#define STIH407_ST231_DMU_SOFTRESET	30
+#define STIH407_ST231_GP0_SOFTRESET	31
+#define STIH407_ST231_GP1_SOFTRESET	32
You've added the #defines, so the DT should compile with v3.

However you don't appear to have added the code which
uses these #defines to drivers/reset/reset-stih407.c. So v3
still won't take the co-processors out of reset.

regards,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help