Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support

Hi Paul,

On 07/09/2015 10:17 AM, Paul Bolle wrote:

quoted

quoted

+static int __exit st_fdma_remove(struct platform_device *pdev)
+{
+	struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
+
+	wait_for_completion(&fdev->fw_ack);
+
+	st_fdma_clk_disable(fdev);
+
+	return 0;
+}

Since this driver is built-in only this means st_fdma_remove() can never
be used, right?

It's not because a driver is built-in only that it does not need a remove callback.
An instance can be probed/removed any time via driver's bind/unbind SysFS entries.
Am I missing something?

Kind regards,
Maxime