Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
From: Brian Norris <hidden>
Date: 2015-08-25 20:34:18
Also in:
linux-arm-kernel, lkml
One more thing... On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/mtd/nand/vf610_nfc.c@@ -0,0 +1,645 @@
...
+struct vf610_nfc {
+ struct mtd_info mtd;
+ struct nand_chip chip;
+ struct device *dev;
+ void __iomem *regs;
+ struct completion cmd_done;
+ uint buf_offset;
+ int page_sz;AFAICT (even with the 2nd patch), you never really use this field. You just set it/increment it, but don't use it for anything. Kill it?
+ /* Status and ID are in alternate locations. */ + int alt_buf; +#define ALT_BUF_ID 1 +#define ALT_BUF_STAT 2 +#define ALT_BUF_ONFI 3 + struct clk *clk; +};
Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html