Thread (8 messages) 8 messages, 2 authors, 2015-08-25

Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation

From: Guenter Roeck <linux@roeck-us.net>
Date: 2015-08-25 19:04:56
Also in: linux-watchdog, lkml

Justin,

On Tue, Aug 25, 2015 at 10:55:40AM -0700, Justin Chen wrote:
Hello Guenter,
quoted
Is 'clock-frequency' really needed (and useful), or would it make more sense
to expect the user to configure a fixed clock if nothing else is available ?
How do other drivers handle this ?
The reason for 'clock-frequency' was for a case where our device tree did not
have clocks. Creating a new fixed clock for a single device seems unnecessary
compared to a 'clock-frequency' property. Their is a use for 'clock-frequency',
but it is not really necessary. However, this is my first linux patch, so I do 
not fully trust my judgement on this...
All that is needed for a fixed clock is a devicetree entry for it. Not sure
I understand your line of argument; you add a lot of complexity and code
just to avoid those few lines in the dts file (especially with 500+
"fixed-clock" nodes in other devicetree files).

Thanks,
Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help