On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote:

On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:

quoted

Driver had coding style issues where spaces were used instead
of tabs. This patch fixes them all.

Signed-off-by: Vaibhav Hiremath <redacted>
---
  drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
  1 file changed, 61 insertions(+), 64 deletions(-)

Same comment as before.

How similar is this file to the other one?

I believe you are referring to include/linux/mfd/88pm80x.h

Can you reduce the size by having shared register defines?

Not sure whether I understand your comment here,
They are common defines.

PM860 only defines are named as

PM860_XXXX

Similarly,
PM805 only defines are named as

PM805_XXXX


and PM800_xxx should be common.

Thanks,
Vaibhav