Re: [PATCH V3 5/6] slimbus: Add support for 'clock-pause' feature
From: Mark Brown <broonie@kernel.org>
Date: 2015-08-15 02:15:43
Also in:
linux-arm-msm, lkml
On Mon, Aug 03, 2015 at 12:59:49AM -0600, Sagar Dharia wrote:
quoted hunk ↗ jump to hunk
@@ -459,6 +459,8 @@ int slim_register_controller(struct slim_controller *ctrl) mutex_init(&ctrl->m_ctrl); spin_lock_init(&ctrl->tx.lock); spin_lock_init(&ctrl->rx.lock); + mutex_init(&ctrl->sched.m_reconf); + init_completion(&ctrl->sched.pause_comp);
Should there not be more interaction with the rest of the framework on clock pauses - the bus will need to be started to do transfers for example?
+#include <linux/slimbus.h> +/**
Missing blank line.
+ * slim_ctrl_clk_pause: Called by slimbus controller to enter/exit 'clock pause'
Is the controller the best place to initiate bus pausing? It's surprising to me that it would be, the bus being idle isn't something that needs controller specific knowledge so I'd expect the framework to have standard support for this.
Attachments
- signature.asc [application/pgp-signature] 473 bytes