Thread (39 messages) 39 messages, 4 authors, 2015-08-09

Re: [PATCH v2 13/22] i2c: core: Probe i2c master devices on demand

From: Wolfram Sang <hidden>
Date: 2015-08-09 12:34:42
Also in: linux-acpi, linux-arm-kernel, linux-i2c, lkml

On Tue, Jul 28, 2015 at 03:19:44PM +0200, Tomeu Vizoso wrote:
When looking up an i2c master through its firmware node, probe it if it
hasn't already.

The goal is to reduce deferred probes to a minimum, as it makes it very
cumbersome to find out why a device failed to probe, and can introduce
very big delays in when a critical device is probed.

Signed-off-by: Tomeu Vizoso <redacted>
What is the status of this series? The boot time reduction sounds great.
quoted hunk ↗ jump to hunk
---

Changes in v2: None

 drivers/i2c/i2c-core.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index e6d4935161e4..5520b413e3db 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1353,6 +1353,8 @@ struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node)
 {
 	struct device *dev;
 
+	fwnode_ensure_device(&node->fwnode);
TBH, the function name doesn't tell me a lot. It ensures what?
+
 	dev = bus_find_device(&i2c_bus_type, NULL, node,
 					 of_dev_node_match);
 	if (!dev)
-- 
2.4.3

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help