On Tue, 2015-08-04 at 18:42 +0100, Mark Brown wrote:

On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:

quoted

Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

Please use subject lines reflecting the style for the subsystem so
people can spot if patches are relevant to them.

OK, I will change the title to "spi: Mediatek: Document devicetree
bindings for spi bus".

quoted

+- clocks: phandles to input clocks.
+
+- clock-names: tuple listing input clock names.
+	Required elements: "main"

...and there are no optional values?

clock tree provides some source clocks, CLK_PERI_SPI0 is the default
one. I will support optional values on the next version.

quoted

+- pad-select: should specify spi pad used, only required for MT8173.
+        This value should be 0~3.

What do the values 0-3 mean?  I guess it's the value for some register
or other part of the device, the binding should say so people can go and
check the datasheet, schematic or whatever to figure out what to set.

This property should be optional, not required

OK, I will explain what the values 0-3 mean.


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html