Thread (5 messages) 5 messages, 3 authors, 2015-08-04

Re: [PATCH v5] powerpc/rcpm: add RCPM driver

From: Chenhui Zhao <hidden>
Date: 2015-08-03 11:14:53
Also in: linuxppc-dev, lkml


On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood [off-list ref] 
wrote:
On Fri, 2015-06-26 at 15:44 +0800, Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:
quoted
 +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
 +{
 +     if (enable)
 +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
 +     else
 +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
 +}
 +
 +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
 +{
 +     if (enable)
 +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
 +     else
 +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
 +}
Why do these take "u32 *mask" instead of "u32 mask"?

-Scott
I think it can be used in the case where there are several mask values.

-Chenhui

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help