Thread (1 message) 1 message, 1 author, 2015-07-29

Re: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles

From: Greg KH <hidden>
Date: 2015-07-29 05:10:16
Also in: linux-arm-kernel

On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote:
quoted hunk
@@ -20,7 +20,6 @@ struct ci_hdrc_platform_data {
 	unsigned long	 flags;
 #define CI_HDRC_REGS_SHARED		BIT(0)
 #define CI_HDRC_SUPPORTS_RUNTIME_PM	BIT(2)
-#define CI_HDRC_DISABLE_STREAMING	BIT(3)
Why not just rename this one, now you have a "hole" in your bit field
that people aren't going to know if they can use or not.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help