Re: [PATCH 2/5] [media] tc358743: enable v4l2 subdevice devnode
From: Hans Verkuil <hidden>
Date: 2015-07-13 10:59:26
Also in:
linux-media
On 07/10/2015 03:11 PM, Philipp Zabel wrote:
quoted hunk
Signed-off-by: Philipp Zabel <redacted> --- drivers/media/i2c/tc358743.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 48d1575..0be6d9f 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c@@ -1668,7 +1668,7 @@ static int tc358743_probe(struct i2c_client *client, state->i2c_client = client; sd = &state->sd; v4l2_i2c_subdev_init(sd, client, &tc358743_ops); - sd->flags |= V4L2_SUBDEV_FL_HAS_EVENTS; + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
Note: HAS_EVENTS won't do much since there are no .subscribe_event or .unsubscribe_event ops. You should add those. Regards, Hans
/* i2c access */
if ((i2c_rd16(sd, CHIPID) & MASK_CHIPID) != 0) {-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html