Re: [PATCH V2] dt: brcm,bcm2835-aux-spi: add binding documentation for new spi-bcm2835aux
From: Stephen Warren <hidden>
Date: 2015-07-11 04:28:41
Also in:
linux-spi
On 06/25/2015 04:54 AM, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
From: Martin Sperl <redacted>
Patch description? I'd suggest deriving this from the first paragraph in the binding doc.
quoted hunk
diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt
quoted hunk
+The BCM2835 contains two forms of SPI master controller, one known simply as +SPI0, and the other known as the "Universal SPI Master"; part of the +auxiliary block. This binding applies to the SPI1/2 controller.
Rather than "SPI1/2", I'd say "this universal SPI master", since the description of the two types of controller doesn't mention that SPI1/2 are the universal SPI master.
+- reg: Should contain register location and length for the spi block + as well as for the common aux block control
Sharing a reg entry between multiple devices almost always turns out to be a mistake. At the very least, the drivers can't claim the region since regions can't be claimed multiple times. Is there any way to avoid this entirely? If not, perhaps you need to create a separate driver to manage the shared register block.