Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP
From: Paul Bolle <hidden>
Date: 2015-07-30 12:48:50
Also in:
linux-arm-kernel, lkml
On do, 2015-07-30 at 12:45 +0100, Lee Jones wrote:
On Wed, 29 Jul 2015, Paul Bolle wrote:quoted
Besides, if I read sti_max_probe() correctly, without OF support loading this module won't accomplish much. So what would another way of autoloading this module buy you?I think this line can be safely removed.
Looking at this patch a little more I notice there's no line reading
MODULE_DEVICE_TABLE(of, sti_mailbox_match);
The three mailbox drivers that currently support OF do have such a line.
So "another way of autoloading" was rather sloppy as now I don't see how
this driver, if build as a module, will get auto-loaded. Maybe there's
an auto-loading mechanism that I'm not aware of here. Or perhaps auto
-loading is not needed.
Similar question for patch 5/6 and the lack of a line reading
MODULE_DEVICE_TABLE(of, mbox_test_match);
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html