On 28/07/15 18:36, Andreas Färber wrote:

Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla:

quoted

This patch adds heart-beat led support on IFC6410.

Signed-off-by: Srinivas Kandagatla <redacted>
---
  arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
index df560cf..1fc2ea5 100644
--- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts

@@ -207,6 +207,19 @@
  			status = "okay";
  		};

+		leds {
+			compatible = "gpio-leds";
+			pinctrl-names = "default";
+			pinctrl-0 = <&notify_led>;
+
+			led@1 {
+				label = "apq8064:green:user1";
+				gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>;
+				linux,default-trigger = "heartbeat";

Can we please drop the heartbeat default? While that's nice as proof of
concept, it's annoying to deliver it that way in Linux distros. Users
can enable that trigger with a simple boot script writing to /sys.

Thanks for the input, I will change to be none, Let the users decide the 
trigger.

thanks,
srini

Thanks,
Andreas

quoted

+				default-state = "on";
+			};
+		};
+
  		qcom,ssbi@500000 {
  			pmicintc: pmic@0 {
  				pm8921_gpio: gpio@150 {

[snip]