Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

Vaibhav Hiremath [off-list ref] writes:

On Monday 20 July 2015 12:39 PM, Vaibhav Hiremath wrote:

quoted

On Monday 20 July 2015 12:36 PM, Vaibhav Hiremath wrote:

quoted

On Saturday 18 July 2015 01:19 AM, Robert Jarzmik wrote:

quoted

Vaibhav Hiremath [off-list ref] writes:

quoted

quoted

So, I applied patches 1-6 to for-next to make some progress.

The others need more thought because of the bindings which shall be
discussed replying to the patches in question.

Thanks for the updated work with lots of proper references.

OK, Thanks and no issues.

Lets discuss more on the bindings.

I made a simple try on my reference platform with the whole patchset.
It oopses on a NULL dereference.

The stack is in [1].
I think it boils down to :
  - i2c_pxa_do_sclk_adj()
    - reg_ilcr = readl(_ILCR(i2c));

I also think the faulty patch is :
  - i2c: pxa: Add ILCR (tLow & tHigh) configuration support

My case, an I2C master case, I'd like you to find the issue and fix it.

Which is this reference platform?
Can you share few details -

  - reference Platform?

Mitac Mio A701, pxa270.

quoted

quoted

  - DT file if you could

None, ran in platform_data mode.

quoted

quoted

  - Boot log (if you could)

You already found the issue, no need for that anymore.

quoted

quoted

I am using pxa1928 based platform, and I do not see any issues.

quoted

Having said that,
I see issues in the patch for non PXA910 platform, where
i2c_pxa_do_sclk_adj() will be called unconditionally and obviously
reg_ilcr and reg_wcr are not set.

Yep.

quoted

I will fix this and send the patch.

This should fix the issue -

Most probably yes.

If you are ok, I will re-spin the patch and submit.

Yes, I'm ok, let's try the next iteration.

Cheers.

-- 
Robert