Re: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC
From: Alexandre Belloni <hidden>
Date: 2015-07-17 23:47:41
Also in:
linux-input, linux-rtc, lkml
On 09/07/2015 at 08:45:54 +0100, S Twiss wrote :
quoted hunk ↗ jump to hunk
From: S Twiss <redacted> Add device tree bindings for the DA9062 RTC driver component Signed-off-by: Steve Twiss <redacted> --- Checks performed with linux-next/next-20150708/scripts/checkpatch.pl da9062.txt total: 0 errors, 0 warnings, 88 lines checked This patch applies against linux-next and next-20150708 Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt index 5765ed9..38802b5 100644 --- a/Documentation/devicetree/bindings/mfd/da9062.txt +++ b/Documentation/devicetree/bindings/mfd/da9062.txt@@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices: Device Supply Names Description ------ ------------ ----------- da9062-regulator : : LDOs & BUCKs +da9062-rtc : : Real-Time Clock da9062-watchdog : : Watchdog Timer ======@@ -41,6 +42,10 @@ Sub-nodes: Documentation/devicetree/bindings/regulator/regulator.txt +- rtc : This node defines settings required for the Real-Time Clock associated + with the DA9062. There are currently no entries in this binding, however + compatible = "dlg,da9062-rtc" should be added if a node is created. + - watchdog: This node defines the settings for the watchdog driver associated with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added if a node is created.@@ -55,6 +60,10 @@ Example: interrupts = <11 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; + rtc { + compatible = "dlg,da9062-rtc"; + }; +
Are those subnodes even parsed? As the parent node is not compatible with "simple-bus" or "simple-mfd", I guess not. You driver is probed from the mfd_cells in da9063-core.c
watchdog {
compatible = "dlg,da9062-watchdog";
};
--
end-of-patch for PATCH RFC V1-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com