Re: [PATCH v2 1/4] clk: mediatek: mt8173: Fix enabling of critical clocks
From: Stephen Boyd <hidden>
Date: 2015-07-06 22:53:04
Also in:
linux-arm-kernel, linux-mediatek, lkml
On 07/02/2015 11:29 PM, Daniel Kurtz wrote:
Hi Stephen, On Fri, Jul 3, 2015 at 7:03 AM, Stephen Boyd [off-list ref] wrote:quoted
On 06/30, James Liao wrote:quoted
From: Sascha Hauer <redacted> On the MT8173 the clocks are provided by different units. To enable the critical clocks we must be sure that all parent clocks are already registered, otherwise the parents of the critical clocks end up being unused and get disabled later. To find a place where all parents are registered we try each time after we've registered some clocks if all known providers are present now and only then we enable the critical clocks Signed-off-by: Sascha Hauer <redacted> Signed-off-by: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> ---Applied to clk-fixesI think James plans to send an updated version of this patch.
Oh right. Well those comments are minor so I'll just fold them in given that I'm rewinding clk-fixes today. I see that comment in init.h about uninitialized variables and __initdata too. I found this 10 year old thread about that [1]. At least with my gcc-4.9 arm compiler I don't see uninitialized __initdata moved to bss. A workaround seems to be to initialize it to NULL in this case, but maybe that doesn't matter because compilers don't have that problem anymore. [1] http://lkml.iu.edu/hypermail/linux/kernel/0512.0/1366.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html