Re: [PATCH v1 1/4] ARM: dts: vfxxx: Add io-channel-cells property for ADC node
From: Stefan Agner <stefan@agner.ch>
Date: 2015-07-03 13:00:32
Also in:
linux-arm-kernel, linux-input, lkml
On 2015-06-30 08:54, Sanchayan Maity wrote:
quoted hunk ↗ jump to hunk
This commit adds io-channel-cells property to the ADC node. This property is required in order for an IIO consumer driver to work. Especially required for Colibri VF50, as the touchscreen driver uses ADC channels with the ADC driver based on IIO framework. Signed-off-by: Sanchayan Maity <redacted> --- arch/arm/boot/dts/vfxxx.dtsi | 2 ++ 1 file changed, 2 insertions(+)diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi index 2c20f3f..f7d8fb6 100644 --- a/arch/arm/boot/dts/vfxxx.dtsi +++ b/arch/arm/boot/dts/vfxxx.dtsi@@ -227,6 +227,7 @@ clocks = <&clks VF610_CLK_ADC0>; clock-names = "adc"; status = "disabled"; + #io-channel-cells = <1>; }; tcon0: tcon@4003d000 {@@ -461,6 +462,7 @@ clocks = <&clks VF610_CLK_ADC1>; clock-names = "adc"; status = "disabled"; + #io-channel-cells = <1>; }; esdhc1: esdhc@400b2000 {
Minor nitpick: can you put the new property one line up? That way it would be sorted alphabetically and status is conveniently still at the end. Otherwise: Acked-by: Stefan Agner <stefan@agner.ch> -- Stefan