Re: [PATCH v4 3/5] clk: add lpc18xx ccu clk driver
From: Joachim Eastwood <hidden>
Date: 2015-06-19 05:17:50
Also in:
linux-arm-kernel, linux-clk
On 19 June 2015 at 00:45, Michael Turquette [off-list ref] wrote:
Quoting Joachim Eastwood (2015-06-10 07:02:59)quoted
Hi Mike,quoted
Hi Joachim, If it were me, I would have broken this up into two tables, one for each CCU. In general I would structure the code to reflect the fact that two different IP blocks are being accessed. This isn't a deal breaker but I thought I would mention it in case you want to make the change. Otherwise this series looks good to me. Let me know if you plan a V5 submission.If there is still time for 4.2 and you don't have any more comments on how the driver uses the DT bindings I would rather send a follow up patch that splits the ccu table for 4.3.quoted
I can take patches #1-4 into the clk tree. Please add my Acked-by to patch #5. I will create an immutable branch to share with the arm-soc tree so that they can take #5 and have access to the dt-bindings headers.Sounds good. I'll talk to arm-soc team about it. But it isn't critical for me to get the DTS changes in for 4.2, but I would be very grateful for getting the drivers and headers in for 4.2 so that 4.3 is ready and doesn't have any header dependencies for all the driver DTS stuff.Patches #1-4 applied to clk-next for 4.2.
Thanks a lot, Mike. regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html