Re: [PATCH v3 3/3] ARM: dts: atlas7: use general dt-binding for hwspinlock

On 06/01/2015 12:33 AM, Barry Song wrote:

2015-05-29 5:30 GMT+08:00 Suman Anna [off-list ref]:

quoted

Barry,

On 05/26/2015 03:28 AM, Barry Song wrote:

quoted

From: Wei Chen <redacted>

This patch moves to use generic dt-binding for hwspinlock providers and
clients.
add #hwlock-cells for the provider and hwlocks for clients.

Cc: Suman Anna <redacted>
Cc: Bjorn Andersson <bjorn-UYDU3/A3LUY@public.gmane.org>
Signed-off-by: Wei Chen <redacted>
Signed-off-by: Barry Song <redacted>
---
 arch/arm/boot/dts/atlas7.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/atlas7.dtsi b/arch/arm/boot/dts/atlas7.dtsi
index a753178..66d3f0e 100644
--- a/arch/arm/boot/dts/atlas7.dtsi
+++ b/arch/arm/boot/dts/atlas7.dtsi

@@ -84,17 +84,17 @@
                      #address-cells = <1>;
                      #size-cells = <1>;

-                     hwspinlock {
+                     hwlock: hwspinlock {
                              compatible = "sirf,hwspinlock";
                              reg = <0x13240000 0x00010000>;

An unrelated question here, why the reg is same for all the child nodes
of the  parent ipc node? If this is partitioned properly, then the
driver can be simplified a bit by using platform_get_resource and
devm_ioremap_resource?

quoted

-
-                             num-spinlocks = <30>;
+                             #hwlock-cells = <1>;
                      };

                      ns_m3_rproc@0 {
                              compatible = "sirf,ns2m30-rproc";
                              reg = <0x13240000 0x00010000>;
                              interrupts = <0 123 0>;
+                             hwlocks = <&hwlock 0>, <&hwlock 1>;

Does this need to be added for the other nodes like ns_m3_rproc@1 as well?

now the hwlock-cells are only added for the nodes who are really using
it. other users have not used it.

OK, may be split it out then and add these in a subsequent patch with
proper usage description.

regards
Suman

quoted

regards
Suman

quoted

                      };

                      ns_m3_rproc@1 {

-barry

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html