Re: [PATCH 2/3] edac: Add L3/SoC support to the APM X-Gene SoC EDAC driver
From: Borislav Petkov <hidden>
Date: 2015-06-01 18:31:14
Also in:
linux-arm-kernel
From: Borislav Petkov <hidden>
Date: 2015-06-01 18:31:14
Also in:
linux-arm-kernel
On Mon, Jun 01, 2015 at 10:46:55AM -0700, Loc Ho wrote:
You are right... Let me just prints the error code instead. Anyone who care will have to do post processing.
Don't forget about the usability of the driver. If a user has to go open manuals when an error happens, you could just as well report naked register values and have a tool decode them. And this strategy (mcelog) turned out to be a real PITA, IMO.
Future or existent next generation may re-define them.
You could easily have a strings array of per-family or per-soc error
descriptions. For an example, take a look at drivers/edac/mce_amd.c
which decodes MCEs on all relevant AMD machines. This is much more
user-friendly than dumping register values which most people have no
idea of where to start looking (and they don't really need to).
HTH.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html