Re: [PATCH v11 4/5] edac: Add APM X-Gene SoC EDAC driver
From: Mark Rutland <hidden>
Date: 2015-06-01 15:17:57
Also in:
linux-arm-kernel
Possibly related (same subject, not in this thread)
- 2015-06-01 · Re: [PATCH v11 4/5] edac: Add APM X-Gene SoC EDAC driver · Catalin Marinas <hidden>
- 2015-06-01 · Re: [PATCH v11 4/5] edac: Add APM X-Gene SoC EDAC driver · Arnd Bergmann <hidden>
- 2015-05-22 · [PATCH v11 4/5] edac: Add APM X-Gene SoC EDAC driver · Loc Ho <hidden>
On Mon, Jun 01, 2015 at 04:11:31PM +0100, Catalin Marinas wrote:
On Mon, Jun 01, 2015 at 04:42:58PM +0200, Arnd Bergmann wrote:quoted
On Friday 22 May 2015 17:32:59 Loc Ho wrote:quoted
+static bool xgene_edac_pmd_l2c_version1(void) +{ + /* Check all chips with PMD L2C version 1 HW */ + #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007) + + switch (MIDR_VARIANT(read_cpuid_id())) { + case 0: + switch (MIDR_REVISION(read_cpuid_id())) { + case 0: + + switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { + case 1: + case 2: + return true; + }; + break; + case 1: + if (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1)) == 1) + return true; + break; + } + break; + case 1: + switch (MIDR_REVISION(read_cpuid_id())) { + case 0: + switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { + case 1: + return true; + }; + break; + case 1: + switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) { + case 1: + case 0: + return true; + }; + break; + } + break; + } +As this is causing build errors on other architectures with COMPILE_TEST now, I'd suggest removing the function completely. Please use different compatible strings for IP blocks that are different and undetectable, instead of reading the ID of another IP block.I fully agree, the MIDR_* macros shouldn't be used by anything under drivers/.
Likewise. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html