Hi Dann,

On Tue, Jun 9, 2015 at 8:31 AM, Dann Frazier [off-list ref] wrote:

On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen [off-list ref] wrote:

quoted

Hi Dann,

On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier [off-list ref] wrote:

quoted

On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen [off-list ref] wrote:

quoted

This patch adds syscon poweroff device node to support poweroff feature
on APM X-Gene Mustang platform

hey Tai,
 The reboot changes work just fine for me, but poweroff does not:

[  OK  ] Reached target Final Step.
         Starting Power-Off...
reboot: Power down
Unable to poweroff system
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000

CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G        W       4.1.0-rc7+ #1
Hardware name: APM X-Gene Mustang board (DT)
Call trace:
[<ffffffc00008990c>] dump_backtrace+0x0/0x11c
[<ffffffc000089a38>] show_stack+0x10/0x1c
[<ffffffc0005b447c>] dump_stack+0x88/0xc8
[<ffffffc0005b3374>] panic+0xe0/0x220
[<ffffffc0000b5f24>] do_exit+0x990/0x994
[<ffffffc0000d06bc>] SyS_reboot+0x14c/0x208
---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000

  -dann

Thanks for testing my patches.
On APM X-Gene Mustang platform, power off circuit is controlled by firmware.
It requires a firmware update to support power off feature.
May I ask what firmware version you're running on?

Sure, 1.15.12.

  -dann

Just want to confirm you are booting in boot strap mode and had
SLIMpro firmware updated to 1.15.12 as well.
To check this, you should see this message in boot loader.

Slimpro FW:
        Ver: 2.4 (build 01.15.12.00 2015/05/20)

I tested on a Mustang A3, this works just fine.

- Tai

quoted

Tai

quoted

quoted

Signed-off-by: Tai Nguyen <redacted>
---
 arch/arm64/boot/dts/apm/apm-mustang.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts
index 83578e7..910d561 100644
--- a/arch/arm64/boot/dts/apm/apm-mustang.dts
+++ b/arch/arm64/boot/dts/apm/apm-mustang.dts

@@ -23,6 +23,18 @@
                device_type = "memory";
                reg = < 0x1 0x00000000 0x0 0x80000000 >; /* Updated by bootloader */
        };
+
+       poweroff_mbox: poweroff_mbox@10548000 {
+               compatible = "syscon";
+               reg = <0x0 0x10548000 0x0 0x30>;
+       };
+
+       poweroff: poweroff@10548010 {
+               compatible = "syscon-poweroff";
+               regmap = <&poweroff_mbox>;
+               offset = <0x10>;
+               mask = <0x1>;
+       };
 };

 &pcie0clk {
--

1.7.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Tai

-- 
Tai
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html