Re: [PATCH v3 15/16] ARM: marvell/dt: add crypto node to armada 370 dtsi
From: Boris Brezillon <hidden>
Date: 2015-05-26 09:03:45
Also in:
linux-crypto
Hi Gregory, On Mon, 25 May 2015 17:33:24 +0200 Gregory CLEMENT [off-list ref] wrote:
Hi Boris, Arnaud, On 22/05/2015 15:34, Boris Brezillon wrote:quoted
From: Arnaud Ebalard <redacted> Add crypto related nodes in armada-370.dtsi. Signed-off-by: Arnaud Ebalard <redacted> Signed-off-by: Boris Brezillon <redacted> --- arch/arm/boot/dts/armada-370.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi index 00b50db5..1255318 100644 --- a/arch/arm/boot/dts/armada-370.dtsi +++ b/arch/arm/boot/dts/armada-370.dtsi@@ -307,6 +307,26 @@ dmacap,memset; }; }; + + crypto@90000 { + compatible = "marvell,armada-370-crypto"; + reg = <0x90000 0x10000>; + reg-names = "regs"; + interrupts = <48>;There is no clocks property. After a quick look on the datasheet, indeed I didn't find any clock which match the CESA. In this case you should update the binding documentation by adding that the clock is optional for armada-370-crypto.
Hm, actually the clock is defined in Marvell's LSP, but not described in the datasheet. Which one should I trust :-) ? Anyway, if this clock appears to be present on armada-370, we'll have to modify the clock driver to account for this before referencing the clock in the crypto node. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com