Re: [PATCH] ARM: dts: Gateworks GW5510 support (i.MX6)

On Thu, Apr 30, 2015 at 9:46 AM, Fabio Estevam [off-list ref] wrote:

Hi Tim,

On Thu, Apr 30, 2015 at 1:01 PM, Tim Harvey [off-list ref] wrote:

quoted

+++ b/arch/arm/boot/dts/imx6dl-gw551x.dts

@@ -0,0 +1,19 @@
+/*
+ * Copyright 2014 Gateworks Corporation
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */

The recommendation for new dts files is to use a dual-license type scheme.

Please check imx6sl-warp for an example.

quoted

+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_5p0v: regulator@0 {
+                       compatible = "regulator-fixed";
+                       reg = <0>;
+                       regulator-name = "5P0V";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       regulator-always-on;

This ' regulator-always-on' can be removed. Same applies to the other
occurrences.

Fabio,

Thanks for the review. I'll post a v2 with these changes.

Tim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html