On Sun, May 10, 2015 at 9:24 PM, Tejun Heo [off-list ref] wrote:

Hello,

On Wed, May 06, 2015 at 12:51:12AM +0530, Suman Tripathi wrote:

quoted

+     switch (version) {
+     case XGENE_AHCI_V1:
+             hpriv->flags = AHCI_HFLAG_NO_NCQ;
+             /*
+              * Override the callbacks for storm ERRATA
+              */
+             xgene_ahci_ops.qc_issue = xgene_ahci_qc_issue;
+             xgene_ahci_ops.softreset = xgene_ahci_softreset;
+             xgene_ahci_ops.pmp_softreset = xgene_ahci_pmp_softreset;

Let's please create separate ops structs for v1 and v2.

Good idea . Will do that .

Thanks.

--
tejun

-- 
Thanks,
with regards,
Suman Tripathi