Thread (8 messages) 8 messages, 2 authors, 2015-05-29

Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

From: Bhuvanchandra DV <hidden>
Date: 2015-05-29 10:11:12
Also in: linux-arm-kernel, linux-serial, lkml

Hello Jakub,

On 05/29/2015 03:34 PM, Jakub Kiciński wrote:
On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
quoted
The LPUART does not provide manual control of RTS/CTS signals,
those can only be controlled by the hardware directly. Therefore
manual control of those signals through mctrl can not be provided.
The current implementation enables/disables the automatic control,
which is not what mctrl should do, hence remove the incorrect
implementation.

Signed-off-by: Bhuvanchandra DV <redacted>
Now that the functions do nothing there is probably no point in keeping
separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.

Thanks! for pointing this.
Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help