Re: [PATCH 6/9] input: goodix: write configuration data to device
From: Mark Rutland <mark.rutland@arm.com>
Date: 2015-05-28 13:21:49
Also in:
linux-input, lkml
On Thu, May 28, 2015 at 01:47:42PM +0100, Irina Tirdea wrote:
quoted hunk ↗ jump to hunk
Goodix devices can be configured by writing this information to the device at init. The configuration data can be provided through the ACPI/device tree property "device-config". If "device-config" is not set, the default device configuration will be used. Signed-off-by: Octavian Purdila <redacted> Signed-off-by: Irina Tirdea <redacted> --- .../bindings/input/touchscreen/goodix.txt | 5 + drivers/input/touchscreen/goodix.c | 143 +++++++++++++++++++++ 2 files changed, 148 insertions(+)diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt index 7137881..9e4ff69 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt@@ -15,6 +15,11 @@ Required properties: - irq-gpio : GPIO pin used for IRQ - reset-gpio : GPIO pin used for reset +Optional properties: + + - device-config : device configuration information (specified as byte + array). Maximum size is 240 bytes.
Generally we frown on passing opaque data. What exactly is encoded in device-config? The description is very vague. Does this correspond to anything in a data sheet or manual? Mark.