Thread (5 messages) 5 messages, 3 authors, 2015-05-22

Re: [PATCH 2/2] drivers: ata: add support for Ceva sata host controller

From: Paul Bolle <hidden>
Date: 2015-05-22 09:34:37
Also in: linux-ide, lkml

[Adding Bjorn.]
On Thu, May 21, 2015 at 09:27:05AM +0530, Suneel Garapati wrote:
quoted
--- /dev/null
+++ b/drivers/ata/ahci_ceva.c
quoted
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
quoted
+MODULE_LICENSE("GPLv2");
You meant "GPL v2".

"GPLv2" is not one of the idents that pass license_is_gpl_compatible().
Loading a module with that ident should trigger a warning and taint the
kernel. See linux/module.h (or linux/license.h) for acceptable idents.

This is a bit of a gotcha. A patch that would have helped here was
posted in https://lkml.org/lkml/2015/4/7/824 . I don't know why that
patch didn't make it into checkpatch.pl. Bjorn?

Thanks,


Paul Bolle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help