Re: [PATCH 1/5] soc: mediatek: Add infracfg misc driver support
From: Paul Bolle <hidden>
Date: 2015-05-21 08:09:53
Also in:
linux-arm-kernel, linux-mediatek, lkml
From: Paul Bolle <hidden>
Date: 2015-05-21 08:09:53
Also in:
linux-arm-kernel, linux-mediatek, lkml
Just a nit: an unneeded macro. On Wed, 2015-05-20 at 16:18 +0200, Sascha Hauer wrote:
--- a/drivers/soc/mediatek/Kconfig +++ b/drivers/soc/mediatek/Kconfig
+config MTK_INFRACFG + bool "MediaTek INFRACFG Support" + depends on ARCH_MEDIATEK + select REGMAP + help + Say yes here to add support for the MediaTek INFRACFG controller. The + INFRACFG controller contains various infrastructure registers not + directly associated to any device. +
--- a/drivers/soc/mediatek/Makefile +++ b/drivers/soc/mediatek/Makefile
+obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o
--- /dev/null +++ b/drivers/soc/mediatek/mtk-infracfg.c
+#include <linux/module.h>
+MODULE_LICENSE("GPL v2");MTK_INFRACFG was changed from tristate to bool in this version. Note that for built-in code MODULE_LICENSE() will be effectively preprocessed away. So you can drop that macro, and the include of linux/module.h too. (I did a quick compile to see if nothing else requires module.h, and it compiled cleanly without that include.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html