Thread (20 messages) 20 messages, 4 authors, 2015-05-21

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

From: Uwe Kleine-König <hidden>
Date: 2015-05-19 19:49:28
Also in: linux-arm-kernel, linux-i2c, linux-mediatek, lkml

Hello Matthias,

On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote:
2015-05-18 20:43 GMT+02:00 Uwe Kleine-König [off-list ref]:
quoted
On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote:
quoted
[...]
 drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++
[...]
+#define I2C_DRV_NAME         "mt-i2c"
i2c-mt65xx ?
As this works for all SoCs so far, I would propose: i2c-mtk
Hmm, currently we have:

  - #define I2C_DRV_NAME mt-i2c
  - dt-compatibles: "mediatek,mt6577-i2c" + "mediatek,mt6589-i2c"
  - function prefix: mtk_i2c_
  - filename: i2c-mt65xx.c
  - Kconfig symbol: I2C_MT65XX

Getting some harmonization here would definitly be nice.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help