Thread (27 messages) 27 messages, 6 authors, 2015-05-21

Re: [PATCH 01/10] pinctrl: mediatek: data struct optimize and remove unused member

From: Linus Walleij <hidden>
Date: 2015-05-19 08:49:24
Also in: linux-arm-kernel, linux-gpio, linux-mediatek, lkml

On Thu, May 14, 2015 at 3:35 AM, Hongzhou Yang
[off-list ref] wrote:
From: Yingjoe Chen <redacted>

struct mtk_desc_pin.chip, mtk_pinctrl_devdata.invser_offset
and mtk_pinctrl_devdata.chip_type are never used in code.
Remove them.

Some per-pin data are using int for pin number and offsets.
Change to short and rearrange to reduce const data size.

Signed-off-by: Yingjoe Chen <redacted>
Signed-off-by: Hongzhou Yang <redacted>
Patch applied.

However I suggest you use:

unsigned int => u32
unsigned short => u16
unsigned char => u8

These kernel-specific types are more to the point,
you immediately see how many bits they use, so a
patch chaning all of the types to u32/u16/u8 would
be welcome.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help