Thread (16 messages) 16 messages, 2 authors, 2015-05-15

Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

From: Stefan Agner <hidden>
Date: 2015-05-15 16:03:01
Also in: linux-arm-kernel, lkml

On 2015-05-15 12:39, Thomas Gleixner wrote:
On Sat, 9 May 2015, Stefan Agner wrote:
quoted
-	irq_chip_unmask_parent(data);
+	if (parent->chip->irq_enable)
+		parent->chip->irq_enable(parent);
+	else
+		parent->chip->irq_unmask(parent);
Why are you not creating irq_chip_enable_parent() which would have
been the proper function anyway?
Will add that...

Btw, have you had a chance to look at 1/12? I added a helper there too
to allow make use of generic chip with IRQ domain hierarchy. In case you
are fine with that general appraoch I will send an updated version of
the patchset with the irq_chip_enable_parent helper soon. 

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help