Re: [PATCH v4 02/13] ARM: dts: exynos4: Use labels for overriding nodesin Exynos4210

W dniu 13.05.2015 o 18:02, Kukjin Kim pisze:

On 05/11/15 22:42, Krzysztof Kozlowski wrote:

quoted

Usage of labels instead of full paths reduces possible mistakes when
overriding nodes.

Well, I'm not sure what kind of the possible mistakes you mentioned...?

One can make a mistake in path when overriding. For example we have:
exynos4.dtsi:
/ {
	gic: interrupt-controller@10490000 {
		...
	};
}

and someone can add in child dtsi (like exynos4210.dtsi):
/ {
	soc {
		interrupt-controller@10490000 {
			cpu-offset = <0x8000>;
		}
	}
}

or he can make a mistake in address.

As a result the gic node won't be properly overridden.

I don't think we need to use the label for gic, combiner.

They are overridden by child DTSI. First definition is in exynos4.dtsi
and exynos4210.dtsi adds a cpu-offset.

Best regards,
Krzysztof