Thread (5 messages) 5 messages, 2 authors, 2015-05-13

Re: [PATCH] clk: bindings: Fix assigned-clock-rates property name

From: Krzysztof Kozlowski <hidden>
Date: 2015-05-06 08:10:20
Also in: linux-clk, lkml

On 06.05.2015 16:45, Stephen Boyd wrote:
On 05/06, Krzysztof Kozlowski wrote:
quoted
In documentation the "assigned-clock-parents" name was used when
describing the "assigned-clock-rates" property.

Signed-off-by: Krzysztof Kozlowski <redacted>
---
Looks right. The whole sentence could use some work though.
quoted
  Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt
index 06fc6d541c89..bf5b0414dc17 100644
--- a/Documentation/devicetree/bindings/clock/clock-bindings.txt
+++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt
@@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks
  and clock frequencies. Such a configuration can be specified in a device tree
  node through assigned-clocks, assigned-clock-parents and assigned-clock-rates
  properties. The assigned-clock-parents property should contain a list of parent
-clocks in form of phandle and clock specifier pairs, the assigned-clock-parents
+clocks in form of phandle and clock specifier pairs, the assigned-clock-rates
  property the list of assigned clock frequency values - corresponding to clocks
This half-sentence:

	The assigned-clock-ratse property the list of assigned
	clock frequency values

doesn't read correctly. Maybe the whole thing should be rewritten
as:

	The assigned-clock-parents property should contain a list
	of parent clocks in the form of a phandle and clock
	specifier pair and the assigned-clock-rates property
	should contain a list of frequencies in Hz. Both these
	properties should correspond to the clocks listed in the
	assigned-clocks property.
Looks much better. So actually this should be yours patch now, you can 
add my Reported-by :).

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help