Thread (14 messages) 14 messages, 3 authors, 2015-03-31

Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available

From: Russell King - ARM Linux <hidden>
Date: 2015-03-27 20:24:59
Also in: linux-arm-kernel, linux-omap, lkml

On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
+	if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
+						       "dma-requests",
+						       &od->dma_requests)) {
+		dev_info(&pdev->dev,
+			 "Missing dma-requests property, using %u.\n",
+			 OMAP_SDMA_REQUESTS);
+		od->dma_requests = OMAP_SDMA_REQUESTS;
+	}
Are all OMAPs including OMAP1 being converted to DT?  If not, don't
introduce noisy printks for which a platform can't do anything about.
Think about this please - if there's no of_node, then why complain
about a missing OF property?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help