Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count
From: Peter Ujfalusi <hidden>
Date: 2015-03-26 12:33:37
Also in:
linux-arm-kernel, linux-omap, lkml
On 03/26/2015 12:57 PM, Vinod Koul wrote:
On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:quoted
Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi <redacted> --- drivers/dma/omap-dma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index 7dd6dd121681..56c33e93dd24 100644 --- a/drivers/dma/omap-dma.c +++ b/drivers/dma/omap-dma.c@@ -22,6 +22,9 @@ #include "virt-dma.h" +#define OMAP_SDMA_REQUESTS 127 +#define OMAP_SDMA_CHANNELS 32Again why dont we put these things in DT ?
They are in DT, the next patch will take the needed information from there and uses these values as fallback values in case they are missing for some reason. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html