Re: [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

On Fri, Mar 20, 2015 at 01:49:12PM -0700, Bjorn Andersson wrote:

On Fri 20 Mar 13:29 PDT 2015, Andy Gross wrote:

quoted

On Thu, Mar 19, 2015 at 06:48:10PM -0700, Bjorn Andersson wrote:

<snip>

quoted

+Example:
+
+	tcsr: syscon@1a400000 {

typo here, syscon@fd484000.  And this syscon is specifically for the tcsr mutex
reg area.

You're right, I didn't read the documentation good enough; let's name it
tcsr-mutex and as this is not the main tcsr region we should fall back
to just having syscon as compatible.

Agreed.  A generic syscon will work until we need to support the other registers
in that block.

But there's still a bunch of other registers in the tcsr-mutex range -
that probably will be consumed by various drivers, so it still makes
sense to have a syscon there.

Agreed.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project