Thread (27 messages) 27 messages, 5 authors, 2015-03-18

Re: [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver

From: Pi-Cheng Chen <hidden>
Date: 2015-03-12 11:16:02
Also in: linux-arm-kernel, linux-pm, lkml

On Thu, Mar 12, 2015 at 5:28 PM, Viresh Kumar [off-list ref] wrote:
On 11 March 2015 at 18:15, Mark Brown [off-list ref] wrote:
quoted
Ugh, no - that's a hideous bodge which is only going to create trouble
later.  Remember, DT is an ABI and should describe the hardware so if
we're doing bodges that are visible there to shoehorn things onto our
implementation that's bad.  The concerns that Pi-Cheng had about what
happens if the PMIC gets changed definitely seem relevant here too.
Hmm..
quoted
Why not just write a custom cpufreq driver if it's too hard to abstract?
Hmm, probably all that can be solved with the new OPP bindings where
we can have support for multiple regulator or clock sources to the CPU.

@Pi-cheng: How are you going to pass voltages for both the regulators
as OPPs today only support a single regulator, in case you have to write
your own driver.
The voltages of the two regulators need to be always under a limitation:
100mV < Vsram - Vproc < 200mV
For now, I just calculate the OPPs of Vsram from OPPs of Vproc.

Another thing I should mention, if the voltage difference of two adjacent
OPPs is greater than 100mV, we need to set the regulator to some
voltages which are not in OPP table considering the limitation above.
I think that will make it more difficult to model such flow in a generic
framework.

Best Regards,
Pi-Cheng
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help