Re: [PATCH v5 5/8] pinctrl: Cygnus: define Broadcom Cygnus GPIO/PINCONF binding
From: Ray Jui <rjui@broadcom.com>
Date: 2015-03-09 16:41:39
Also in:
linux-arm-kernel, linux-gpio, lkml
From: Ray Jui <rjui@broadcom.com>
Date: 2015-03-09 16:41:39
Also in:
linux-arm-kernel, linux-gpio, lkml
Hi Linus, On 3/9/2015 9:30 AM, Linus Walleij wrote:
On Thu, Mar 5, 2015 at 1:35 AM, Ray Jui [off-list ref] wrote:quoted
Document the GPIO/PINCONF device tree binding for Broadcom Cygnus SoC Signed-off-by: Ray Jui <rjui@broadcom.com> Reviewed-by: Scott Branden <sbranden@broadcom.com>(...)quoted
+- ngpios: + Total number of GPIOs the controller providesRemind me again. Why don't we know this from the compatible string?
Is hard coding the number of GPIO pins in the driver based on compatible string the preferred approach? If so, I can make the change. Note the current driver only has one compatible string "brcm,cygnus-gpio." To do this, I need to introduce 3 compatible strings "brcm,cygnus-asiu-gpio", "brcm,cygnus-ccm-gpio", "brcm,cygnus-aon-gpio", and assign hard coded ngpios to each of them during probe.
(I paused applying the patches here waiting for the answer.) Yours, Linus Walleij