Thread (36 messages) 36 messages, 6 authors, 2015-03-27

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

From: Krzysztof Kozlowski <hidden>
Date: 2015-03-09 11:03:01
Also in: linux-input, linux-pm, lkml

2015-03-09 1:35 GMT+01:00 Beomho Seo [off-list ref]:
On 03/08/2015 05:13 AM, Sebastian Reichel wrote:
quoted
On Mon, Mar 02, 2015 at 07:10:35PM +0900, Jaewon Kim wrote:
quoted
From: Beomho Seo <redacted>

This patch adds device driver of max77843 charger. This driver provide
initialize each charging mode(e.g. fast charge, top-off mode and constant
charging mode so on.). Additionally, control charging paramters to use
i2c interface.

Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Beomho Seo <redacted>
Reviewed-By: Sebastian Reichel <sre@kernel.org>

I can't take it as is, since it depends on the private header file
of PATCHv1.

-- Sebastian
This patch reviewed by Sebastian.
Could you Please merge that your git tree ?
Hi,

... and again we are adding a new driver for very similar chipset to
already supported. I looked at spec and the charger's registers are
almost the same as for max77693. Their layout and addresses are the
same. I see some minor differences, probably the most important would
be different values current (fast-charge, top-off). But still 90% of
registers are the same... Do we really have to add new driver?

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help