Thread (65 messages) 65 messages, 10 authors, 2015-03-18

Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver

From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Date: 2015-03-04 12:08:12
Also in: linux-api, linux-arch, linux-arm-kernel, linux-gpio, linux-serial, lkml

2015-03-03 20:43 GMT+01:00 Paul Bolle [off-list ref]:
Maxime Coquelin schreef op ma 02-03-2015 om 17:53 [+0100]:
quoted
Do you agree if I define it like this:

config ARMV7M_SYSTICK
    bool "Clocksource driver for ARMv7-M System timer"
    depends on OF && (CPU_V7M || COMPILE_TEST)
    select CLKSRC_OF
    select CLKSRC_MMIO
    help
      This options enables clocksource support for the ARMv7-M system
      timer unit.
I don't really have strong feelings on whatever way you choose to fix
the, well, minor problem I pointed out.

Having said that, if a Kconfig entry without a prompt (and therefor,
without help) actually does what you want it to do, why bother adding a
prompt and a one line help text?
This is because I added also support for COMPILE_TEST coverage as per
Uwe advice,
and thought it was necessary to have an entry for this.
Maybe I'm just wrong?

Thanks,
Maxime

Paul Bolle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help