On Thu, Feb 26, 2015 at 10:25 AM, Kumar Gala [off-list ref] wrote:

On Feb 23, 2015, at 1:54 AM, Srinivas Kandagatla [off-list ref] wrote:

quoted

This patch adds rpm node to apq8064 dt as rpm would be used by other
devices for regulator support. Also adds all the regulators in the rpm.

Signed-off-by: Srinivas Kandagatla <redacted>

[..]

quoted

+                     interrupts      = <0 19 0>, <0 21 0>, <0 22 0>;
+                     interrupt-names = "ack", "err", "wakeup";
+

Can you use the defines for GIC for the interrupts.  Also, I think the last property should probably be level high instead of 0.

The code sets it to rising, but better move that to the dt (as you suggest).

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html