Re: [PATCH 06/14] drivers: reset: Add STM32 reset driver
From: Andreas Färber <afaerber@suse.de>
Date: 2015-02-15 23:59:29
Also in:
linux-api, linux-arch, linux-arm-kernel, linux-gpio, linux-serial, lkml
Am 12.02.2015 um 18:45 schrieb Maxime Coquelin:
quoted hunk ↗ jump to hunk
The STM32 MCUs family IP can be reset by accessing some shared registers. The specificity is that some reset lines are used by the timers. At timer initialization time, the timer has to be reset, that's why we cannot use a regular driver. Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> --- .../devicetree/bindings/reset/st,stm32-reset.txt | 19 ++++ drivers/reset/Makefile | 1 + drivers/reset/reset-stm32.c | 124 +++++++++++++++++++++ 3 files changed, 144 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-reset.txt create mode 100644 drivers/reset/reset-stm32.cdiff --git a/Documentation/devicetree/bindings/reset/st,stm32-reset.txt b/Documentation/devicetree/bindings/reset/st,stm32-reset.txt new file mode 100644 index 0000000..add1298 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/st,stm32-reset.txt@@ -0,0 +1,19 @@ +STMicroelectronics STM32 Peripheral Reset Controller +==================================================== + +Please also refer to reset.txt in this directory for common reset +controller binding usage. + +Required properties: +- compatible: Should be "st,stm32-reset" +- reg: should be register base and length as documented in the + datasheet +- #reset-cells: 1, see below + +example: + +reset_ahb1: reset@40023810 { + #reset-cells = <1>; + compatible = "st,stm32-reset"; + reg = <0x40023810 0x4>; +};
[snip] RM0090 has two different chapters on the RCC IP: * Reset and clock control for STM32F42xxx and STM32F43xxx (RCC) * Reset and clock control for STM32F405xx/07xx and STM32F415xx/17xx(RCC) I therefore feel it is wrong to use "stm32-" here; instead I used "st,stm32f429-rcc" (also relates to 12/14 discussion). This may apply to other identifiers, too. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html