Re: [PATCH v2] ARM: dts: zynq: Add OCM node
From: Michal Simek <hidden>
Date: 2015-02-12 15:16:04
Also in:
linux-arm-kernel, lkml
On 02/12/2015 03:58 PM, Sören Brinkmann wrote:
On Thu, 2015-02-12 at 12:01PM +0100, Michal Simek wrote:quoted
On 02/12/2015 11:54 AM, Mark Rutland wrote:quoted
On Thu, Feb 12, 2015 at 10:42:47AM +0000, Michal Simek wrote:quoted
Add OCM node for all zynq boards. OCM location can changed but for all current boards this is the location where OCM is.` Signed-off-by: Michal Simek <redacted> --- Changes in v2: - Move node to board file suggested by Mark This patch is done based on discussion here. https://lkml.org/lkml/2014/12/1/396 Mark: I expect you won't like amba bus reference or am I wrong?I'm fine with dropping things onto a bus in this way. If we're happy to do it for other nodes I don't see why busses should be special.Wonderful. I will give people some time to comment this style.Given that the location is discoverable, wouldn't it make sense to let 'reg' point to the ctrl/cfg registers in the SLCR and let the driver handle the whereabouts of the OCM location? (but I guess this is going in circles now, such a proposal was on the table at some point, IIRC). But I'd prefer: memory-controller@0xfffc0000 { /* the address here would of course not match all configurations */ interrupts = ...; syscon = &slcr; };
That was discussed with Arnd at that link above. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel