RE: [PATCH][v4] power/fsl: add MDIO dt binding for FMan

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, January 30, 2015 10:44 AM
To: Xie Shaohui-B21989
Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
Emilian-EMMEDVE1
Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan

On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote:

quoted

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, January 30, 2015 8:54 AM
To: shh.xie@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Medve
Emilian-EMMEDVE1; Xie Shaohui-B21989
Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan

On Wed, 2015-01-28 at 19:54 +0800, shh.xie@gmail.com wrote:

quoted

+- interrupts
+		Usage: required
+		Value type: <prop-encoded-array>
+		Definition: Event interrupt of external MDIO controller.

What if this MDIO controller is not "external"?  Should Usage say
"required for external MDIO"?

[S.H] I thought the definition can tell the interrupt is for external
MDIO, I can change the Usage to "required for external MDIO" in next

version.

quoted

how about other parts, are they OK?

Yes.  I'll fix it up when applying.

Thank you!

Shaohui

N�����r��y���b�X��ǧv�^�)޺{.n�+���z��z��z)���w*jg���
�����ݢj.�۰\��M��gj��a����' ��ޢ�
���j:+v���w�j�m��������zZ+�����ݢj"��!�i